Fixing inefficiency in pyttb.tenrand.
#428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version was creating random data as a multway arraw, reordering it to Fortran order (expensive and pointless), and then called the tensor constructor. Instead, we exploit the fact that we can just pass a 1D random array and then reshape that into the desired shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version was creating random data as a multiway array, reordering it to Fortran order (expensive and unnecessary), and then called the tensor constructor. Instead, we exploit the fact that we can just pass a 1D random array and then reshape that into the desired shape. While the reordering makes little difference for small tensors, it can get quite expensive at scale.
📚 Documentation preview 📚: https://pyttb--428.org.readthedocs.build/en/428/