feat: add vyos script, general cleanup/updates#13
Conversation
c07f270 to
57335cf
Compare
|
@cmulk @GhostofGoes Need a maintainer to approve to test the workflow. It should make all the images in parallel using the matrix builds, but I haven't been able to test it. |
f5cea2b to
5932b3f
Compare
638847f to
a1f1dc1
Compare
|
That was a nice lesson in Github workflows. It's ready now 😎 |
|
@GhostofGoes thanks for the re-run. Guess it was just a fluke? |
Yeah that was odd, probably typical CI flakiness. I'll review this later and merge, if it happens again then we can always hunt down the root cause and fix it in a later PR. I'd rather have a build happening most of the time than no build at all :) |
GhostofGoes
left a comment
There was a problem hiding this comment.
A few minor notes. Excellent work! That Makefile is a thing of beauty.
There was a problem hiding this comment.
Well what I originally meant was "I will add the vyos build steps to sceptre-phenix-images CI" but this entire rework is good too :)
Current build is failing because vyos is down for maintenance, but i will check again in a bit and I can merge probably today.
Then I have some more images i want to add to the mix!
|
@glattercj yes it just hasn't done a release yet, which is scheduled once a week. I'll go ahead and do am manual run so we have the first release with these changes |


Vyos / Updates
Description
This PR adds a VyOS 1.5 build script that has been tested to work with phenix.
Warning
The VyOS image from this PR requires sandialabs/sceptre-phenix#241 to be merged.
Related Issue
Resolves sandialabs/sceptre-phenix#227
Type of Change
Please select the type of change your pull request introduces:
Checklist
Additional Notes
Vanilla Linux Images
kali-tools-top10Experiment Linux Images
Note
See
scripts/vyos/README.mdfor notes about the new VyOS build