Skip to content

feat: add vyos script, general cleanup/updates#13

Merged
cmulk merged 2 commits intosandialabs:mainfrom
glattercj:feat/vyos
Aug 16, 2025
Merged

feat: add vyos script, general cleanup/updates#13
cmulk merged 2 commits intosandialabs:mainfrom
glattercj:feat/vyos

Conversation

@glattercj
Copy link
Copy Markdown
Contributor

@glattercj glattercj commented Aug 9, 2025

Vyos / Updates

Description

This PR adds a VyOS 1.5 build script that has been tested to work with phenix.

Warning

The VyOS image from this PR requires sandialabs/sceptre-phenix#241 to be merged.

Related Issue

Resolves sandialabs/sceptre-phenix#227

Type of Change

Please select the type of change your pull request introduces:

  • Bugfix
  • New feature
  • Documentation update
  • Other (please describe):

Checklist

  • This PR conforms to the process detailed in the Contributing Guide.
  • I have included no proprietary/sensitive information in my code.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested my code.

Additional Notes

  • The repo scripts were reorganized
  • A Makefile was added to assist with creating images
  • The README was updated
  • The Github actions were updated
  • Additional images were added to the github workflow:

Vanilla Linux Images

Target OS / Release Includes Notes GUI?
bookworm Debian / bookworm
kali Kali / kali-rolling kali-tools-top10
jammy Ubuntu / jammy
noble Ubuntu / noble

Experiment Linux Images

Target OS / Release Includes Notes GUI?
bennu Ubuntu / jammy Bennu, Brash Official SCEPTRE image used for running bennu in experiments (includes brash shell)
docker-hello-world Ubuntu / jammy Docker Shows how you can run a service (dockerd) inside the chroot image build environment
ntp Ubuntu / jammy ntpd Network time protocol server
vyos VyOS / 1.5 VyOS Open-source enterprise-grade router platform

Note

See scripts/vyos/README.md for notes about the new VyOS build

@glattercj glattercj marked this pull request as draft August 9, 2025 18:54
@glattercj glattercj force-pushed the feat/vyos branch 5 times, most recently from c07f270 to 57335cf Compare August 10, 2025 02:50
@glattercj glattercj marked this pull request as ready for review August 10, 2025 02:51
@glattercj
Copy link
Copy Markdown
Contributor Author

@cmulk @GhostofGoes Need a maintainer to approve to test the workflow. It should make all the images in parallel using the matrix builds, but I haven't been able to test it.

@glattercj glattercj force-pushed the feat/vyos branch 18 times, most recently from f5cea2b to 5932b3f Compare August 10, 2025 16:22
@glattercj glattercj marked this pull request as draft August 10, 2025 16:23
@glattercj glattercj force-pushed the feat/vyos branch 18 times, most recently from 638847f to a1f1dc1 Compare August 13, 2025 11:16
@glattercj
Copy link
Copy Markdown
Contributor Author

glattercj commented Aug 14, 2025

That was a nice lesson in Github workflows. It's ready now 😎

@GhostofGoes @cmulk

@glattercj
Copy link
Copy Markdown
Contributor Author

¯_(ツ)_/¯ This is the same workflow on my fork:

image

vs the one ran here:

image

@glattercj
Copy link
Copy Markdown
Contributor Author

@GhostofGoes thanks for the re-run. Guess it was just a fluke?

@GhostofGoes
Copy link
Copy Markdown
Collaborator

@GhostofGoes thanks for the re-run. Guess it was just a fluke?

Yeah that was odd, probably typical CI flakiness. I'll review this later and merge, if it happens again then we can always hunt down the root cause and fix it in a later PR. I'd rather have a build happening most of the time than no build at all :)

Copy link
Copy Markdown
Collaborator

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor notes. Excellent work! That Makefile is a thing of beauty.

Copy link
Copy Markdown
Contributor

@cmulk cmulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well what I originally meant was "I will add the vyos build steps to sceptre-phenix-images CI" but this entire rework is good too :)

Current build is failing because vyos is down for maintenance, but i will check again in a bit and I can merge probably today.

Then I have some more images i want to add to the mix!

@glattercj
Copy link
Copy Markdown
Contributor Author

@cmulk do you know why the tag and release were skipped? It's not adding :latest to the images.

@cmulk
Copy link
Copy Markdown
Contributor

cmulk commented Aug 17, 2025

@glattercj yes it just hasn't done a release yet, which is scheduled once a week. I'll go ahead and do am manual run so we have the first release with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]VYOS image builder not working

3 participants