Skip to content

feat: Add ot-sim/pandapower image#25

Merged
cmulk merged 2 commits intosandialabs:mainfrom
xdnewlun1:main
Mar 28, 2026
Merged

feat: Add ot-sim/pandapower image#25
cmulk merged 2 commits intosandialabs:mainfrom
xdnewlun1:main

Conversation

@xdnewlun1
Copy link
Copy Markdown
Contributor

@xdnewlun1 xdnewlun1 commented Mar 24, 2026

Adding OT-Sim Image

Description

Added ot-sim.qc2 image for support of OT-Sim integration, image comes with Helics, OT-Sim, Pandas, PyPower. Pushing for reproducibility and use in ot-sim integrations to SCEPTRE.

Type of Change

Please select the type of change your pull request introduces:

  • Bugfix
  • New feature
  • Documentation update
  • Other (please describe):

Checklist

  • This PR conforms to the process detailed in the Contributing Guide.
  • I have included no proprietary/sensitive information in my code.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested my code.

Additional Notes

None

@cmulk cmulk self-assigned this Mar 27, 2026
@cmulk cmulk self-requested a review March 27, 2026 16:17
@cmulk cmulk marked this pull request as draft March 27, 2026 16:17
Copy link
Copy Markdown
Contributor

@cmulk cmulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also squash commits, e.g.:

git reset 2e1e1c7973237fec96886b4edeb4b5b6dff3a289  --soft
git commit -m "feat: add ot-sim image"
git push --force

# Build ot-sim.qc2 -- Ubuntu Focal, OTSim, Pandas,
ot-sim:
@$(CHECK_IMAGE)
@$(PHENIX) image create -r focal -T $(CURDIR)/scripts/ot-sim.sh $(UBUNTU_MIRROR) $(COMPRESS) $(@)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be bumped up to jammy?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pydnp3 library utilized by otsim only supported up to ubuntu 20 focal, and I have not gotten it working on Ubuntu 22

@cmulk cmulk changed the title OT-Sim Image feat: Add ot-sim/pandapower image Mar 27, 2026
@cmulk cmulk marked this pull request as ready for review March 27, 2026 17:11
@cmulk cmulk merged commit 2fb2eb8 into sandialabs:main Mar 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants