fix: update VM snapshot functions to work with mm vm migrate #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimega `vm migrate` command was recently updated to generate both a memory state file as well as a disk hdd file. This commit updates the relevant phenix functions that are called to generate and restore VM snapshots to use the new files accordingly.
glattercj
approved these changes
Dec 9, 2025
Collaborator
glattercj
left a comment
glattercj
left a comment
There was a problem hiding this comment.
Nice, deleting raw qmp interactions and using native (mm) functions 👍
LGTM
Collaborator
|
@activeshadow sandia-minimega/minimega#1587 merged! Is this still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: update VM snapshot functions to work with mm vm migrate
Description
The minimega
vm migratecommand was recently updated to generate both a memory state file as well as a disk hdd file. This commit updates the relevant phenix functions that are called to generate and restore VM snapshots to use the new files accordingly.Related Issue
closes #246
Type of Change
Please select the type of change your pull request introduces:
Checklist
Additional Notes
This PR also relies on minimega PR sandia-minimega/minimega#1587, so once it's merged we can update the minimum minimega version in the relevant config files for this repo.