Update exomerge3 to work with (some) shell topologies#790
Open
japlews wants to merge 2 commits intosandialabs:masterfrom
Open
Update exomerge3 to work with (some) shell topologies#790japlews wants to merge 2 commits intosandialabs:masterfrom
exomerge3 to work with (some) shell topologies#790japlews wants to merge 2 commits intosandialabs:masterfrom
Conversation
Co-authored-by: Peter Coffin <pcoffin@sandia.gov>
Contributor
|
Looks good to me. |
Author
Collaborator
|
@japlews Hi Julia, it appears that you have a formatting error in the python changes that you made. The Linter (flake8) is complaining about the format of the tuples you introduced. The unit tests are also failing due to this change. It would be appreciated if you could also add new unit tests for this new functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply piggyback on
quad4logic to support shells inexomerge3.