Conduit json corruption fix#797
Merged
tokusanya merged 3 commits intosandialabs:masterfrom Apr 9, 2026
Merged
Conversation
refactored to expose conduit json node creation to test added test which fails on incorrect loop iterator (without &) and succeeds on correct loop iterator (with &) issue was that conduit node was copied by auto iterator instance so when result node was given "set_external()" that node then went away at end of loop; fix was to change to an auto address node, i.e. "auto cp" got changed to "auto& cp"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Iocatalyst_CatalystManager.C, when multiple inputs are being sent to the same catalyst script, there is a loop through the saved conduit nodes to transfer them (via set_external, not set) to catalyst. The loop had an incorrect iterator which was causing the copying and deletion of a conduit node rather than using a reference. This pull request fixes that issue, refactors the method so that we could expose the issue to testing, and adds a test to make sure the corruption does not occur (and the test fails correctly and the corruption occurs when the iterator is incorrect).