Open
Conversation
Contributor
Author
|
I guess this probably shouldn't be pushed since it contains more commits than just the fix to the filesystem api... Forgot that my clone had some changes relative to sandialabs/seacas... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filesystem_typefunction was returing astring_view. However, on the mac system, the value that was being returned was on the stack and left a dangling reference. Changed the api to return astd::stringinstead.This function probably isn't being used much or at all yet, so should not break anyone to change the public api; alternative is to depreacate this function and add a new good function, but it seems like overkill, but am also ok if that is the approach that is desired.