Skip to content

Ioss fix filesystem type api#811

Open
gsjaardema wants to merge 9 commits intosandialabs:masterfrom
gsjaardema:ioss-fix-filesystem-type-api
Open

Ioss fix filesystem type api#811
gsjaardema wants to merge 9 commits intosandialabs:masterfrom
gsjaardema:ioss-fix-filesystem-type-api

Conversation

@gsjaardema
Copy link
Copy Markdown
Contributor

The filesystem_type function was returing a string_view. However, on the mac system, the value that was being returned was on the stack and left a dangling reference. Changed the api to return a std::string instead.

This function probably isn't being used much or at all yet, so should not break anyone to change the public api; alternative is to depreacate this function and add a new good function, but it seems like overkill, but am also ok if that is the approach that is desired.

@gsjaardema
Copy link
Copy Markdown
Contributor Author

gsjaardema commented Apr 21, 2026

I guess this probably shouldn't be pushed since it contains more commits than just the fix to the filesystem api...
Most of the other changes are probably good except for the change to use my account on the docker push...

Forgot that my clone had some changes relative to sandialabs/seacas...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant