Distribution extra spack cleanup #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix tests to be robust to non-breaking api changes. Also, change binary asset check so it is not recursive. This avoids an infinite loop in some environments.
The distribution command was including files specific to the user's spack environment were getting bundled along with spack. This is becasue spack writes into its root directory as it is being used. This creates a more exhaustive list of locations to avoid copying along with spack and more agressively asserts they don't end up in the final spack installation
Collaborator
Author
|
@psakievich, this should do a better job being precise about our spack copy. It looks to me like the CI had a systemic failure. |
psakievich
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distribution command was including files specific to the user's spack environment
were getting bundled along with spack. This is because spack writes into its root
directory as it is being used. This creates a more exhaustive list of locations
to avoid copying along with spack and more aggressively asserts they don't end up in
the final spack installation