fix: improve WebDAV path compatibility - #25
Merged
Conversation
Summary - Add WebDAV-side percent encoding for path segments that are not unescaped R7RS identifiers, with decoding for directory listings. - Add minimal LOCK/UNLOCK handling and advertise class-2 WebDAV methods for clients like macOS Finder. - Allow file-manager ledger collection probes without trailing slashes. - Clarify WebDAV API-token authentication docs and ignore local compose env files. - Bump platform patch metadata to 1.3.1. Testing - cd services/file-system && go test ./... - ./records/tests/test.sh /home/tdinh/projects/sync-web/journal/target/debug/journal-sdk - Live smoke tested against https://djali.net WebDAV with macOS Finder, Nautilus/GVFS, and rclone/WinFsp paths. Notes/Risks - Windows built-in WebClient remains best-effort; rclone + WinFsp is the recommended Windows path. - WebDAV percent decoding is a service convention only; ledger paths continue to store atomic Scheme symbol names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LOCK/UNLOCKhandling and advertise class-2 WebDAV methods for clients like macOS Finder..envfiles.1.3.1.timedependency to avoid a floatingtime/cookiecompile failure in container smoke builds.Testing
cd services/file-system && go test ./..../records/tests/test.sh /home/tdinh/projects/sync-web/journal/target/debug/journal-sdkcd journal && cargo test --no-runhttps://djali.netWebDAV with macOS Finder, Nautilus/GVFS, and rclone/WinFsp paths.Notes/Risks
Cargo.lockor otherwise make Rust image builds fully deterministic.