save server CLI commands to the config file #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aptimex
reviewed
Jun 5, 2025
src/cmd/configure.go
Outdated
| err = os.WriteFile(c.configFileServer, []byte(peer.CreateServerFile(serverConfigRelay, serverConfigE2EE)), 0600) | ||
| file, err := os.Create(c.configFileServer) | ||
| if err != nil { | ||
| fmt.Printf("error creating server config file: %v", err) |
Collaborator
There was a problem hiding this comment.
This error string should be saved to the fileStatusServer variable and formatted using the same RedBold() and Red() that the other errors use.
Also, if this error is triggered it should skip over the rest of this new code since the file.WriteString() call is going to fail if the file creation fails.
Aptimex
reviewed
Jun 5, 2025
src/cmd/configure.go
Outdated
|
|
||
| data := []string{ | ||
| peer.CreateServerFile(serverConfigRelay, serverConfigE2EE), | ||
| peer.CreateServerCommand(serverConfigRelay, serverConfigE2EE, peer.POSIX, c.simple, c.disableV6), |
Collaborator
There was a problem hiding this comment.
The strings that need to be commented should just have a # added to them here instead of using a loop to add them later. Like "# " + peer..... Note that there should also be a space after the # to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the creation of the server file. Creates the file and reads the data using slices of string type. Prepends '#' to the CLI commands so they are comments.
Addresses issue: #53