Modernize TypeScript example with Vitest and ESLint 9#97
Open
josegarrera wants to merge 8 commits intosandromancuso:masterfrom
Open
Modernize TypeScript example with Vitest and ESLint 9#97josegarrera wants to merge 8 commits intosandromancuso:masterfrom
josegarrera wants to merge 8 commits intosandromancuso:masterfrom
Conversation
- Delete tslint.json (TSLint deprecated since 2019) - Add eslint.config.js with flat config format - Configure @typescript-eslint for TypeScript support
- Add vitest.config.ts with globals enabled - Configure test file pattern for test directory
- Replace Jest with Vitest ~3.0.0 - Upgrade TypeScript from 2.x to ~5.7.2 - Add ESLint ~9.17.0 with typescript-eslint ~8.18.0 - Remove deprecated jest, ts-jest, tslint, @types/jest - Add ESM support with "type": "module" - Update npm scripts for new tooling
- Target ES2022 with ESNext modules - Enable strict mode for better type safety - Use bundler module resolution - Include test directory in compilation - Rename output directory from built to dist
Vitest globals are enabled in config, no import needed
- Update Node.js requirement to 20+ LTS - Document new npm scripts for Vitest and ESLint
- Add underscore prefix to unused parameter in TripDAO - Configure ESLint to ignore underscore-prefixed args - Add vitest/globals types to tsconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Plan
npm installsucceedsnpm run lintpassesnpm run typecheckpassesnpm testruns (placeholder test fails intentionally as kata setup)