fix: correct launchUrl typo and promote demo test from xfail

[Kunall7890]

Problem

Fixes #3615

commands/loginDemo.js had a typo on the first .url() call:

// ❌ Before
.url(this.launchUrl + "/demo")

this.launchUrl does not exist in Nightwatch — the correct property
is this.launch_url (snake_case). This caused the browser to navigate
to undefined/demo instead of the actual server URL, making the demo
login test fail immediately on every run.

Changes

tests/commands/loginDemo.js

• Fixed typo: this.launchUrl → this.launch_url

tests/tests/basic.js

• Removed the if (run_xfail) guard around Test demo login command
• The test is now a regular test alongside the other two
• Removed unused run_xfail import

How to Verify

RUN_XFAIL=true ./run-tests.sh

Test demo login command should now pass instead of failing
on the first navigation step.

[ocdtrekkie]

The test didn't pass in CI. I'm actually guessing though that could be because of #3765.

[Kunall7890]

Hi @ocdtrekkie — thanks for the review!

Understood on #3765 potentially causing the CI failure. Since this is a
pre-existing build issue unrelated to my changes, would you be able to
confirm whether the fix itself looks correct to you?

Happy to rebase or make any other adjustments needed on my end.

[ocdtrekkie]

@mnutt Michael, how do you think we can test this?

[mnutt]

@Kunall7890 it looks like Sandstorm changed the copy from "Demo" to "Create Account" back in 2015. I made a small change here: mnutt@df12f950

If you want to pull it into your branch you could do:

git fetch https://github.com/mnutt/sandstorm.git mn/demo-login-launch-url-v2
git cherry-pick df12f950
git push