Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service - Merge develop into master #1063

Merged
merged 41 commits into from
Jul 18, 2023
Merged

Service - Merge develop into master #1063

merged 41 commits into from
Jul 18, 2023

Conversation

BenTopping and others added 30 commits June 30, 2023 15:12
- makes it easier to match the test to the task
- reorder well options to match DB option_versions.id order
Note: this will intentionally fail as it is a rude duplicate
Update rubocop 1.52.1 → 1.54.0 (minor)
- only posts coverage details and does not block PRs
…heck to remove destroyed wells from sequencing kit box barcode validation
@harrietc52 harrietc52 changed the title Merge develop into master Service - Merge develop into master Jul 17, 2023
Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks good to me) 🙂

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@b437225). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1063   +/-   ##
=========================================
  Coverage          ?   97.46%           
=========================================
  Files             ?      349           
  Lines             ?     9953           
  Branches          ?        0           
=========================================
  Hits              ?     9701           
  Misses            ?      252           
  Partials          ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@harrietc52 harrietc52 merged commit aa69b2e into master Jul 18, 2023
8 checks passed
@harrietc52
Copy link
Collaborator Author

harrietc52 commented Jul 18, 2023

Production Deployment

Including:

Steps

  • Merge develop into master, for UI, Service and UWH
  • Check all Pacbio plates have plate_number
  • Deploy Traction Service (Current prod: v6.0.0)

ansible-playbook -vv deploy_traction_service.yml -i environments/<env> -e "github_branch=v6.1.0" -e "full_deploy=true reload_nginx=true skip_migrations=true"

  • Rebroadcast to back populate MLWH plate_number

Pacbio::Run.all.each { |run| Messages.publish(run, Pipelines.pacbio.message) }

  • Deploy Unified Warehouse, run the migrations (Current prod: v1.15.0)

ansible-playbook -vD deploy_unified_warehouse.yml -i environments/<env> -e "github_branch=v1.16.0" -e "full_deploy=true skip_migrations=false"

  • Deploy Traction UI (Current prod: v7.0.0)

ansible-playbook -vD deploy_traction_ui.yml -i environments/<env> -e "github_branch=v7.1.0"

@harrietc52
Copy link
Collaborator Author

harrietc52 commented Jul 18, 2023

Deployment issues

Issues ran in to whilst rebroadcasting the Pacbio::Runs from Production

  • There were 6 Pacbio::Requests with no samples, therefore the message to include a request.sample.name failed
Pacbio::Request.all.count
# 4521

# Pacbio::Request's ids with no sample
# 3016, 3017, 3018, 3019, 3020, 3023

Pacbio::Run.all.count
=> 686
  • There were 5 Pacbio::Runs that therefore needed to be excluded from the rebroadcast
Pacbio::Request.find(3023).libraries.map(&:pool).map(&:wells).flatten.map(&:plate).map(&:run).map(&:id)

# Request id -> run id

# 3016, 530
# 3017, 509
# 3018, 522
# 3019, 530
# 3020, no run
# 3023, 531

Pacbio::Run.where.not(id: [530, 509, 522, 530, 531]).count
=> 682
  • The Runs were excluded when rebroadcasting
Pacbio::Run.where.not(id: [530, 509, 522, 530, 531]).each { |run| Messages.publish(run, Pipelines.pacbio.message) }

runs_updated = _
[#<Pacbio::Run:0x00007f3be1ad2ce8
...
runs_updated.count
=> 682
  • 3398 records in the pac_bio_run MLWH table were updated to have plate_number: 1. The 17526 records that were not updated are not Traction Pacbio runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants