-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service - Merge develop into master #1063
Conversation
…arcode constraints
- makes it easier to match the test to the task
- reorder well options to match DB option_versions.id order
Note: this will intentionally fail as it is a rude duplicate
- prevents issue with the option input not matching numbers to strings - https://psd-team.slack.com/archives/CKH9T2E3T/p1688379358393429
…ent type validation config
Update rubocop 1.52.1 → 1.54.0 (minor)
- only posts coverage details and does not block PRs
…heck to remove destroyed wells from sequencing kit box barcode validation
…code-constraints DPL-764 - Revio sequencing kit box barcode constraints
🚨 [security] Update rails 7.0.5 → 7.0.6 (patch)
dev: add code coverage
Update seeding data for v11 and v12_revio
Update rubocop 1.54.0 → 1.54.1 (patch)
Updated pacbio message config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (looks good to me) 🙂
Codecov Report
@@ Coverage Diff @@
## master #1063 +/- ##
=========================================
Coverage ? 97.46%
=========================================
Files ? 349
Lines ? 9953
Branches ? 0
=========================================
Hits ? 9701
Misses ? 252
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Production DeploymentIncluding:
Steps
|
Deployment issuesIssues ran in to whilst rebroadcasting the Pacbio::Runs from Production
|
Changes proposed in this pull request:
Coupled with:
sanger/traction-ui#1263
sanger/unified_warehouse#525