Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop into Master #1071

Merged
merged 40 commits into from
Jul 26, 2023
Merged

Develop into Master #1071

merged 40 commits into from
Jul 26, 2023

Conversation

stevieing
Copy link
Collaborator

@stevieing stevieing commented Jul 26, 2023

Closes #

Changes proposed in this pull request:

  • Two plate sample sheets
  • Only load config files of known pipelines
  • Depfu updates
  • Test refactoring
  • Reduce test ouptput

StephenHulme and others added 30 commits July 3, 2023 16:22
🚨 [security] Update sanitize 6.0.1 → 6.0.2 (patch)
Update rubocop 1.54.1 → 1.54.2 (patch)
…712b52465

[Snyk] Security upgrade flipper-ui from 0.25.2 to 0.25.3
DPL-745: Implement 2-plate sample sheets for Revio
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1071 (f935f40) into master (65e734e) will increase coverage by 0.06%.
Report is 11 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   97.46%   97.52%   +0.06%     
==========================================
  Files         349      349              
  Lines        9953    10159     +206     
==========================================
+ Hits         9701     9908     +207     
+ Misses        252      251       -1     
Files Changed Coverage Δ
app/csv_generator/pacbio_sample_sheet.rb 94.44% <100.00%> (+2.77%) ⬆️
app/models/concerns/pipelineable.rb 100.00% <100.00%> (ø)
app/models/concerns/sample_sheet.rb 100.00% <100.00%> (ø)
app/pipelines/pipelines.rb 92.59% <100.00%> (+0.59%) ⬆️
app/validators/pipeline_validator.rb 100.00% <100.00%> (ø)
spec/csv_generator/pacbio_sample_sheet_spec.rb 100.00% <100.00%> (ø)
spec/factories/pacbio/runs.rb 100.00% <100.00%> (ø)
spec/lib/tasks_spec.rb 94.18% <100.00%> (+0.51%) ⬆️
spec/models/pacbio/well_spec.rb 100.00% <100.00%> (ø)
spec/pipelines/pacbio/sample_sheet_spec.rb 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stevieing stevieing merged commit 23c1d53 into master Jul 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants