Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1102 dpl 892 as a long read user robin i need a new tag set for ont for the new assay type hotfix #1104

Conversation

stevieing
Copy link
Collaborator

Closes #

Changes proposed in this pull request:

  • Added ONT SQK-RBK114.96 tag set.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check version

@stevieing stevieing changed the base branch from develop to master September 8, 2023 13:02
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1104 (09ff6bc) into master (37b3555) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         346      346           
  Lines       10106    10115    +9     
=======================================
+ Hits         9853     9862    +9     
  Misses        253      253           
Files Changed Coverage Δ
lib/tasks/create_tags.rake 96.00% <100.00%> (+0.39%) ⬆️
spec/lib/tasks_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a release version bump

@stevieing stevieing merged commit 88cbced into master Sep 11, 2023
8 checks passed
@stevieing stevieing deleted the 1102-dpl-892-as-a-long-read-user-robin-i-need-a-new-tag-set-for-ont-for-the-new-assay-type-hotfix branch October 19, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-892 - As a long Read User (Robin) I need a new tag set for ONT for the new assay type
2 participants