DPL-947 dna control barcode v12 sequel i ie #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1143 +/- ##
========================================
Coverage 97.64% 97.64%
========================================
Files 369 369
Lines 11002 11003 +1
========================================
+ Hits 10743 10744 +1
Misses 259 259
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
seenanair
changed the title
stevieing
requested changes
Nov 8, 2023
| return if record.send(required_attribute).present? | ||
| # If versions are specified, check that the record's smrt_link_version version | ||
| # is included in the list | ||
| if versions.present? && versions.exclude?(record.smrt_link_version.name) |
There was a problem hiding this comment.
I think we can remove this now.
config/pacbio_instrument_types.yml
Outdated
| # TODO: fix this to have separate behaviour for v11 and v12 (see commit 05bfe764a8eafe) | ||
| required_attributes: | ||
| options: | ||
| versions: |
There was a problem hiding this comment.
We can definitely remove the versions code but wait to hear back from Craig as to whether this needs to be required. It wasn't previously.
| @@ -5,7 +5,7 @@ | |||
| class MyClass | |||
| include ActiveModel::Model | |||
|
|
|||
| attr_accessor :attr_a, :attr_b, :attr_c, :attr_d | |||
| attr_accessor :attr_a, :attr_b, :attr_c, :attr_d, :smrt_link_version | |||
There was a problem hiding this comment.
Again I think we can take this out now.
stevieing
requested changes
Nov 8, 2023
| class RequiredAttributesValidator < ActiveModel::Validator | ||
| attr_reader :required_attributes | ||
| attr_reader :required_attributes, :versions |
There was a problem hiding this comment.
Versions aren't needed anymore?
There was a problem hiding this comment.
Sorry, missed out. Removed now 👍
stevieing
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNA control complex box barcode set as a required field in v12 Sequel IIe
dpl947_enable_dna_control_barcode_pacbio_sequel_ii_v12)pacbio_instrument_types_v1pacbio_instrument_types_v2-dna_control_complex_box_barcodeset as required_attribute"Samplesheet
dna_control_complex_box_barcodefield addedSMRT Link Version v11 made inactive in the rake task and database for UAT