Skip to content

fix(s3_bucket_downloader): add redownload mode for missing files #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

sangshuduo
Copy link
Owner

  • Introduced a new redownload mode to check existing files and only download missing ones.
  • Added a command-line argument to enable this feature.
  • Updated progress reporting to reflect the number of existing and missing files.

- Introduced a new redownload mode to check existing files and only download missing ones.
- Added a command-line argument to enable this feature.
- Updated progress reporting to reflect the number of existing and missing files.
Copy link
Contributor

mentatbot bot commented Apr 2, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

Copy link
Contributor

@mentatbot mentatbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this PR and the implementation looks good! The redownload mode is a useful feature that will help save bandwidth and time by only downloading missing files.

Some notes on the implementation:

  • The command-line argument is properly added with good documentation
  • The file existence checking logic is clear and straightforward
  • The progress reporting is updated appropriately to show existing vs. missing file counts
  • The early return when no files need downloading is a good optimization

The code maintains the existing behavior when redownload mode is not enabled, which is great.

One small suggestion: the thread progress message changed from showing detailed counts to a simpler "by Thread X" message. This seems less informative than before, but it's a minor UI detail.

Overall, this is a well-implemented feature that adds useful functionality. Approving!

@sangshuduo sangshuduo merged commit 814130f into main Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant