Skip to content

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Oct 18, 2023

Allows using pathlib paths for TLS certificate directories and cert/key filenames. Previously only str was accepted on app.run(ssl=...).

@Tronic Tronic requested a review from a team as a code owner October 18, 2023 23:49
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5a9658) 88.387% compared to head (340fea7) 88.430%.

❗ Current head 340fea7 differs from pull request most recent head cc29f01. Consider uploading reports for the commit cc29f01 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2840       +/-   ##
=============================================
+ Coverage   88.387%   88.430%   +0.043%     
=============================================
  Files           92        92               
  Lines         7156      7157        +1     
  Branches      1228      1228               
=============================================
+ Hits          6325      6329        +4     
+ Misses         575       574        -1     
+ Partials       256       254        -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ChihweiLHBird
ChihweiLHBird previously approved these changes Nov 6, 2023
Copy link
Member

@ChihweiLHBird ChihweiLHBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants