feat: add SERVER_NAME to passthru config if specified in app config #3067
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not work as expected:
Problem
I would have expected my SERVER_NAME update to have propagated to workers, especially since doing this on
main_process_start
, but this is not the case. Because I have SANIC_SERVER_NAME env var set to some different value, all my workers still take that value, even though I just updated it with a new value.Solution
With this PR, code above now works, and I can optionally change my SERVER_NAME at
main_process_start
and all my workers will have the correct SERVER_NAME.