refactor: consolidate agent rules into sanity-best-practices skill - #23
Conversation
Migrate all 21 .mdc agent rules from rules/ into the sanity-best-practices skill as the single source of truth, following the agentskills.io spec. - Move comprehensive guides to skills/sanity-best-practices/references/ (e.g., sanity-nextjs.mdc → references/nextjs.md) - Rename rules/ → references/ per agentskills.io specification - Convert .mdc frontmatter to standard .md (add title/tags, drop alwaysApply) - Update all internal cross-references to new paths - Rewrite SKILL.md with Quick Reference index (Vercel pattern) - Add compiled AGENTS.md inside skill with all 26 atomic rules - Update root AGENTS.md Knowledge Router to point to new locations - Update README.md with new repository structure - Delete all 21 old rules/sanity-*.mdc files (clean break) - All 4 skills pass validation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Review from Claude Code Review: consolidate agent rules into sanity-best-practices skillSummaryThe amended PR addresses the concerns from the initial review. This is a clean consolidation — good to go. What it doesMerges the 26 atomic rule files and 21 guide/integration files into 22 unified reference files under What's good
Delivery channels all accounted for
|
Delete 25 atomic reference files that duplicated content already covered by the comprehensive topic guides (groq.md, schema.md, etc.). Unique content from atomics (optimizable filters table, defineMigration example, compound cursor pattern, icon mapping table, stegaClean alternatives, etc.) was merged into the corresponding guide before deletion. Also makes migration.md an index that points to migration-html-import.md for the HTML deep-dive, keeping the pattern extensible for future migration guides. Updates SKILL.md and AGENTS.md to reflect the consolidated structure (47 → 22 reference files).
fix: Migrate rules to skills fixes
Fixed in #24 |
runeb
left a comment
There was a problem hiding this comment.
Looks good — concerns from the initial review have been addressed.
Summary
.mdcagent rules fromrules/into thesanity-best-practicesskill as the single source of truthrules/→references/per the agentskills.io specificationAGENTS.mdinside the skill (Vercel pattern) with all 26 atomic rulesSKILL.mdwith a comprehensive Quick Reference indexAGENTS.mdKnowledge Router to point to new locationsrules/sanity-*.mdcfiles (clean break, no stubs)What changed
rules/sanity-nextjs.mdcskills/sanity-best-practices/references/nextjs.mdrules/sanity-schema.mdcskills/sanity-best-practices/references/schema.mdskills/.../rules/groq-*.mdskills/.../references/groq-*.md.mdcfrontmatter.mdfrontmatter with title/tagsMCP impact
list_sanity_rules/get_sanity_rulesreads from the skill's references directory — will need to be updated to read fromreferences/instead ofrules/Test plan
npm run validate.mdcfiles remainingrules/sanity-references in any.mdor.jsonfilereferences/(21 guides + 26 atomic rules +_sections.md)list_sanity_rulesstill works after server-side update🤖 Generated with Claude Code