feat: add support for event functions#111
Merged
Merged
Conversation
Signed-off-by: Simon MacDonald <simon.macdonald@gmail.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
📚 TypeDoc Generation Result✅ TypeDoc generated successfully!
The TypeDoc JSON file has been generated and validated. All documentation scripts completed successfully. |
snocorp
approved these changes
Jun 4, 2026
| errors.push({type: 'invalid_value', message: '`type` must be `sanity.function.event`'}) | ||
| } | ||
|
|
||
| errors.push(...validateFunction(functionResource)) |
Contributor
There was a problem hiding this comment.
Curious why you add these errors at the end instead of at the beginning of the validation.
Contributor
Author
There was a problem hiding this comment.
I don't actually know why that is the last step before returning. I was just following the same convention as all the other validators in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a step towards the unified
defineFunction. For now I'm adding this sugar methoddefineEventFunctionso that I can get the necessary types into@sanity/blueprintsso that I can add events toblueprints-resource-function. These will be generic events without queue semantics.What to review
Testing
Added new tests to cover the new definer function.