-
Notifications
You must be signed in to change notification settings - Fork 1
fix(docs): flatten types for typedoc #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
📚 TypeDoc Generation Result✅ TypeDoc generated successfully!
The TypeDoc JSON file has been generated and validated. All documentation scripts completed successfully. |
| * dayOfWeek: '*', | ||
| * }, | ||
| * name: 'daily-cleanup', | ||
| * event: {expression: 'every day at 9am'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have another example shows the cron expression as well?
defineScheduleFunction({
name: 'daily-cleanup',
event: {expression: '0 9 * * *'},
})There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so too. I will merge #69 into this and then move a couple examples around and see where we're at.
This function is still "@hidden" so there's opportunity to add more docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|

need to merge #69 first
use
@expandto help inline/flatten docs. particularly for all definer functions++ miscellaneous fixes and tuning
also "FUTURE example"s to show kitchen-sink+references. they may not work yet so they don't make it into the docs yet (
/*vs/**)bonus: upload generated HTML as an artifact of the PR. bummed I couldn't find a way to make it viewable in the browser yet. one day