refactor: extract emptyAuth object to avoid duplication in getStudioWorkspaces#1240
Merged
Conversation
Contributor
|
⏳ Bundle Stats — Calculating bundle sizes for @sanity/cli, @sanity/cli-core, create-sanity... |
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI’s Studio workspace resolution (getStudioWorkspaces) to reuse a single shared “empty auth” store across all workspaces, preventing Sanity’s auth-divergence warning from firing due to per-workspace stub auth objects being different references (as described in #1239).
Changes:
- Extracted a shared
emptyAuthobject and reused it for allunauthedWorkspaces - Avoided creating one empty auth store (and empty client) per workspace during
resolveConfig()input preparation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Coverage Delta
Comparing 1 changed file against main @ Overall Coverage
|
stipsan
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should fix #1239
What to review
Testing