Conversation
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (85605dd) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 1.0 KB | - |
| Bundled (raw) | 11.16 MB | +182 B, +0.0% |
| Bundled (gzip) | 2.10 MB | +52 B, +0.0% |
| Import time | 874ms | -18ms, -2.0% |
bin:sanity
| Metric | Value | vs main (85605dd) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.01s | -23ms, -1.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (85605dd4)
| Metric | Value | vs main (85605dd) |
|---|---|---|
| Internal (raw) | 106.7 KB | +33 B, +0.0% |
| Internal (gzip) | 26.7 KB | +25 B, +0.1% |
| Bundled (raw) | 21.72 MB | +33 B, +0.0% |
| Bundled (gzip) | 3.46 MB | +24 B, +0.0% |
| Import time | 777ms | +10ms, +1.3% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (85605dd4)
| Metric | Value | vs main (85605dd) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage Delta
Comparing 3 changed files against main @ Overall Coverage
|
…fineApp Deploy needs to know whether an app is a Sanity-owned singleton. Accept and thread `isSingleton` the same way as `applicationType`: validated by the schema, hidden from the public `DefineAppInput`, and readable via `getWorkbench` in the deploy command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
unstable_defineAppnow accepts an internalisSingleton: booleanand threads it through to thedeploycommand. It's hidden from the publicDefineAppInputtype the same wayapplicationTypeis — validated by the schema, omitted from the user-facing surface, set by Sanity-owned apps via@ts-expect-error.Deploy needs to know whether an app is a Sanity-owned singleton; this wires the flag to where the deploy command can read it (
getWorkbench(cliConfig).isSingleton), without exposing it to user apps.Closes SDK-1786.
What to review
applicationTypealready takes: schema →isWorkbenchAppnarrowing (cli-core) →resolveWorkbenchApp→getWorkbench(deploy).isSingletonis a pure passthrough flag, unlikeapplicationTypewhich is inferred when absent.DefineAppInputstill hides the field (type-surface test asserts it).Testing
Added unit coverage: schema validation, type-surface exclusion, loader clone preservation, and that the flag reaches the deploy accessor. Typecheck, lint, depcheck and the affected suites all pass.