feat!: replace tsx loader with jiti based ts loader#458
Draft
feat!: replace tsx loader with jiti based ts loader#458
Conversation
|
Claude finished @binoy14's task in 2m 16s —— View job PR Review
3 issues found: 1. Stale JSDoc in The comment still says "thin wrapper around tsx" after switching to jiti. // packages/@sanity/cli-core/src/util/importModule.ts:24
* This is a thin wrapper around tsx to allow swapping out the underlying implementation in the future if needed.2. Stale JSDoc in The comment says "Executes a worker file with tsx registered" but jiti is now used. // packages/@sanity/cli-core/src/loaders/ts/tsWorkerTask.ts:19
* Executes a worker file with tsx registered.3. Dead null check in
// packages/@sanity/cli/src/actions/exec/execScript.ts:28-31
const jitiLoaderPath: string = import.meta.resolve('@rexxars/jiti', import.meta.url)
if (!jitiLoaderPath) {
throw new Error('@sanity/cli not able to resolve jiti loader')
}Remove the null check, or wrap the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

feat!: replace tsx loader with jiti based ts loader
fix: replace tsx loader in exec script with jiti