-
Notifications
You must be signed in to change notification settings - Fork 35
feat: add sanity client interface type #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stipsan
wants to merge
13
commits into
main
Choose a base branch
from
add-sanity-client-interface-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
SanityClientTypeinterface is to solve problems we often see withSanityClientand duplicate instances of@sanity/clientinnode_modules:These errors are confusing and frustrating. The reason why our generated
SanityClientclass types ends up with the#privatemarker is due to us using private properties to ensure implementation details like#httpRequestcan't be accessed onclient.httpRequest.There isn't a way for us to use the private property while also not ending up with the strict and brittle typing for
SanityClient.The solution I've landed on is to expose a new interface,
SanityClientType, that theSanityClientclass has to implement.This works well for type checking, as the
#privateproperty is no longer there, and the union logic TypeScript is known and loved for is used, making the client no longer so sensitive to duplicates innode_modules.