Move all tests to ./tests/ with new Go module to isolate testing dependencies
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombender
reviewed
Apr 30, 2025
| runTestWithCfg(t, name, &standardCfg, cases...) | ||
| } | ||
|
|
||
| func diffStrings(t *testing.T, expected, actual string) (*string, bool) { |
There was a problem hiding this comment.
To be clear, it was very intentional to use diff here. assert.Equal() produces super unreadable unified diffs. If you want different output, I'd be fine with an environment variable to control it (defaulting to diff).
There was a problem hiding this comment.
Reverted, fwiw the pure go diff is a lot faster
atombender
reviewed
Apr 30, 2025
tests/go.mod
Outdated
| @@ -0,0 +1,16 @@ | |||
| module github.com/sanity-io/litter/tests | |||
|
|
|||
| go 1.23.7 | |||
There was a problem hiding this comment.
Might as well use latest (1.24.0?) and also update the root go.mod?
There was a problem hiding this comment.
Updated in tests module, shouldn't update the main one unless necessary, libraries automatically get compiled with the version of their consumer, this is a minimum, and litter doesn't use any >1.16 features so I don't see why you'd break it for no reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tests/package, which is its own go module, to isolate testing dependencies from the main packageassert.Equalinstead of thediffshellout, which may be uglier but is more reliable, was making a fuss about trailing newlines or something I didn't want to debug