Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 7, 2025

Closes #[issue_number]

Description

24 test suites were disabled on Windows with .skipIf(isWindows). Root cause: PATH environment variable constructed using Unix : separator instead of Windows ;.

Changes

  • test/env/spawnProject.ts & test/env/globalSetup.ts: Replace hardcoded : with path.delimiter for cross-platform PATH construction
  • test/node.test.ts & test/cli.test.ts: Remove all .skipIf(isWindows) guards (24 total)
// Before
PATH: `${process.env['PATH']}:${path.resolve(__dirname, '../../bin')}`

// After  
PATH: `${process.env['PATH']}${path.delimiter}${path.resolve(__dirname, '../../bin')}`

Node's path.delimiter returns : on Unix, ; on Windows.

Original prompt

This section details on the original issue you should resolve

<issue_title>Lots of tests are disabled on windows</issue_title>
<issue_description>There are many test suites that are disabled with .skipIf(isWindows). All tests should instead be passing on windows and whatever is causing them to fail should be fixed.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: f90b9c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Fix disabled tests for Windows environment Fix Windows test failures caused by hardcoded Unix PATH separator Nov 7, 2025
Copilot AI requested a review from stipsan November 7, 2025 17:24
@stipsan stipsan marked this pull request as ready for review November 7, 2025 17:27
@stipsan stipsan enabled auto-merge (squash) November 7, 2025 17:31
@stipsan stipsan disabled auto-merge November 7, 2025 17:34
@stipsan stipsan merged commit 40f2862 into main Nov 7, 2025
8 checks passed
@stipsan stipsan deleted the copilot/fix-disabled-tests-on-windows branch November 7, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lots of tests are disabled on windows

2 participants