-
Notifications
You must be signed in to change notification settings - Fork 5
Add configurable strict checks for legacy package.json fields #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d8e6318 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: stipsan <[email protected]>
Co-authored-by: stipsan <[email protected]>
Co-authored-by: stipsan <[email protected]>
…ith warnings Co-authored-by: stipsan <[email protected]>
Co-authored-by: stipsan <[email protected]>
|
@copilot you got some failing checks there buddy |
All checks are now passing! ✅
The implementation is working as expected with all new strict checks defaulting to warnings. |
Co-authored-by: stipsan <[email protected]>
|
@copilot remove the |
Co-authored-by: stipsan <[email protected]>
|
@copilot Use PackageJson in the new rule names, instead of TopLevel. And run |
Co-authored-by: stipsan <[email protected]>
Done! Renamed all strict options to use Changes:
Also added a changeset file ( All tests passing ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the changeset entry should reflect the entire PR, not the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the changeset in commit d8e6318 to reflect the entire PR:
- Documents all 5 new strict options added
- Explains the purpose and default behavior (warn)
- Lists breaking changes (removal of
alwaysPackageJsonMain) - Notes that
typesfield is still required for npm listings
The changeset now provides a comprehensive overview of the feature for the changelog.
Co-authored-by: stipsan <[email protected]>
Implementation Complete ✅
Updated the changeset to comprehensively describe the entire PR, not just the last commit.
Changeset Now Includes:
noPackageJsonMain,noPackageJsonModule,noPackageJsonBrowser,noPackageJsonTypesVersions,preferModuleType)warnlevelalwaysPackageJsonMainoptiontypesfield still being requiredThe changeset now provides a complete overview of this feature for users reviewing the changelog.
Original prompt
mainandmodulefields inpackage.jsonwhen--strict#2201✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.