-
Notifications
You must be signed in to change notification settings - Fork 5
Validate publishConfig.exports values match exports #2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: cfaeae7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@copilot test fail |
Co-authored-by: stipsan <[email protected]>
Co-authored-by: stipsan <[email protected]>
Co-authored-by: stipsan <[email protected]>
The test failure is due to JavaScript heap running out of memory during the full test suite execution. The new |
|
@copilot fix failed checks |
Co-authored-by: stipsan <[email protected]>
Fixed TypeScript compilation errors in cfaeae7:
The build now passes successfully and all tests are working. |
Stricter
publishConfig.exportsvalidationloadPkgWithReporting.tsnode.require,node.import)pnpm changeset addto document the changesChanges Made
areExportValuesEqual()helper function to recursively compare export valuesSummary
This PR implements stricter validation for
publishConfig.exportsto ensure that the values in publishConfig match the values in exports (after removing source/development conditions). This prevents publishing packages to npm with incorrect paths that would lead to crashes.The validation is always enabled and cannot be turned off with strictOptions, as these checks are critical for package correctness.
Original prompt
publishConfig.exportsvalidation #2384💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.