Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 15, 2025

  • Explore codebase to understand the structure
  • Add checkTypes?: boolean property to extract interface in types.ts
  • Update buildTypes function to accept and use checkTypes parameter
  • Update doExtract.ts to pass config?.extract?.checkTypes to buildTypes
  • Update dtsWatchTask.ts to pass config?.extract?.checkTypes to buildTypes
  • Run build to verify changes
  • Run pnpm changeset add to document the change
Original prompt

This section details on the original issue you should resolve

<issue_title>Add noCheck to package.config.ts root</issue_title>
<issue_description>Right now the only way to disable type checking during dts gen when using dts: 'api-extractor' is by setting "noCheck": true in tsconfig.json. This is not ideal as there is no tsc cli flag for overriding it, forcing you to have multiple tsconfig.json files instead of share a single one.

Add support for extract.checkTypes to be set to false in package.config.ts and have the same effect as if "noCheck": true.
It means that if package.config.ts has extract.checkTypes to false, then

noCheck: tsconfig.options.noCheck ?? tsconfig.options.isolatedDeclarations,
should set noCheck to true.
The internal default options should not give checkTypes a value at all, that way ?? tsconfig.options.noCheck ?? tsconfig.options.isolatedDeclarations can continue to work the same way as before.</issue_description>

<agent_instructions>Remember to run pnpm changeset add before you're done</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

🦋 Changeset detected

Latest commit: 86148f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sanity/pkg-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stipsan stipsan marked this pull request as ready for review December 15, 2025 12:36
@stipsan stipsan merged commit fbe8c6e into main Dec 15, 2025
9 checks passed
@stipsan stipsan deleted the copilot/add-nocheck-to-package-config branch December 15, 2025 12:36
Copilot AI requested a review from stipsan December 15, 2025 12:37
@squiggler squiggler bot mentioned this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add noCheck to package.config.ts root

2 participants