Fix noCheck warning when extract.checkTypes is false #2403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
noCheckwarning was shown even whenextract.checkTypes = falseinpackage.config.ts, despite this option having the same effect as settingnoCheck: trueintsconfig.json.Changes
extract.checkTypes = false: Added condition check to skip the warning when type checking is already disabled via package confignoCheck: trueintsconfig.jsonorextract: { checkTypes: false }inpackage.config.tsThe logic already exists in
buildTypes.tswherecheckTypes: falsesetsnoCheck: true:The warning condition now respects this equivalence.
Original prompt
noCheckwarning is shown whenextract.checkTypesisfalse#2402💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.