fix: prevent deprecation warning in php ^8.1 #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using this library in PHP ^8.1 causes this deprecation warning:
This PR adds the mentioned annotation
#[\ReturnTypeWillChange], which silences the deprecation without breaking compatibility to older PHP-Versions by specifying the return type.The annotation is seen as a comment by older PHP-Versions.
What to review
jsonSerializedwas annotated with#[\ReturnTypeWillChange]in these files:lib/Path.phplib/Selection.phplib/Transaction.phpTesting
No deprecation warning present after applying the patch.