feat: support using the same instance for different datasets #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
judofyr
force-pushed
the
holm/dataset-bound
branch
from
1c97ac7 to
f6786b1
Compare
judofyr
force-pushed
the
holm/require-project-id
branch
from
2cbcac0 to
8b5e9b8
Compare
judofyr
force-pushed
the
holm/dataset-bound
branch
from
f6786b1 to
9a3e862
Compare
This was referenced Sep 24, 2025
This was referenced Sep 24, 2025
judofyr
force-pushed
the
holm/dataset-bound
branch
from
9a3e862 to
7029e15
Compare
judofyr
force-pushed
the
holm/require-project-id
branch
from
8b5e9b8 to
5c97111
Compare
judofyr
changed the base branch from
holm/require-project-id
to
graphite-base/632
judofyr
force-pushed
the
graphite-base/632
branch
from
5c97111 to
39345d2
Compare
judofyr
force-pushed
the
holm/dataset-bound
branch
from
7029e15 to
0698478
Compare
judofyr
changed the base branch from
graphite-base/632
to
holm/require-project-id
judofyr
force-pushed
the
holm/dataset-bound
branch
from
0698478 to
0f7802b
Compare
judofyr
changed the base branch from
holm/require-project-id
to
graphite-base/632
judofyr
force-pushed
the
graphite-base/632
branch
from
39345d2 to
d1b957f
Compare
judofyr
force-pushed
the
holm/dataset-bound
branch
from
0f7802b to
6992e87
Compare
judofyr
changed the base branch from
graphite-base/632
to
holm/actions-unify
judofyr
force-pushed
the
holm/dataset-bound
branch
from
6992e87 to
e99e804
Compare
This introduces the concept of a "key" for a store. The main goal here is to enable the support for us using a single SanityInstance across all the stores, but still have separate stores per projectId/dataset. This is accomplished by saying that each store is determined by a "key" which can be dynamically built from the options. We first invoke the key logic and then dispatches to the right store. For now have projectId/dataset keys, but in the future we expect this to be per-resource. This also means that it's possible to use a single SanityInstance for working with multiple projectId/dataset. If you pass in an explicit projectId/dataset then it will no longer care about the configuration on the SanityInstance.
judofyr
force-pushed
the
holm/dataset-bound
branch
from
e99e804 to
9b9fc3a
Compare
cngonzalez
approved these changes
Dec 19, 2025
Member
cngonzalez
left a comment
cngonzalez
left a comment
There was a problem hiding this comment.
Appreciate the lack of breaking changes to any exported utils! Also did some manual testing in those places where there could have been some divergence (how the client is retrieved in the perspective store, for example), and saw no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces the concept of a "key" for a store. The main goal here is to enable the support for us using a single SanityInstance across all the stores, but still have separate stores per projectId/dataset. This is accomplished by saying that each store is determined by a "key" which can be dynamically built from the options. We first invoke the key logic and then dispatches to the right store. For now have projectId/dataset keys, but in the future we expect this to be per-resource.
This also means that it's possible to use a single SanityInstance for working with multiple projectId/dataset. If you pass in an explicit projectId/dataset then it will no longer care about the configuration on the SanityInstance.
What to review
Testing
Fun gif