fix(deps): unpin tsx via catalog now that Node 24 regression is resolved#936
fix(deps): unpin tsx via catalog now that Node 24 regression is resolved#936binoy14 wants to merge 1 commit into
Conversation
Reverts the `tsx <4.22.0` pin added in #922 to dodge a Node 24 regression in tsx's `?tsx-namespace=` query propagation, which broke `@sanity/pkg-utils`' `pkg build` (it loads `package.config.ts` via `tsImport` from `tsx/esm/api`). tsx 4.22.4 (privatenumber/tsx#803, "resolve CommonJS directory requires inside dependencies") fixes the surface the SDK hits. Verified locally on Node 24.13.0: clean `core`+`react` `pkg build` runs pass on 4.22.4. Moves the version into a pnpm `catalog` so the root and `@repo/e2e` share one source of truth instead of two literal specifiers, and drops the now-unnecessary `pnpm.overrides` ceiling. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This change is part of the following stack: Change managed by git-spice. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @binoy14's task in 47s —— View job Review
No actionable issues found. The change is correct and self-consistent:
The |
|
⏳ Bundle Stats — Calculating bundle sizes for @sanity/sdk, @sanity/sdk-react... |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Coverage Report
File CoverageNo changed files found. |
|
Closing — the premise ("Node 24 regression is resolved") is incorrect. tsx 4.22.4 still breaks The Root cause is a Node patch-specific regression: tsx 4.22.4 passes on Node 24.13.0 (what local was running) but fails on Node 24.16.0 (what This is tracked upstream and still open: privatenumber/tsx#801 (repro is literally |
Reverts the
tsx <4.22.0pin added in #922 to dodge a Node 24regression in tsx's
?tsx-namespace=query propagation, which broke@sanity/pkg-utils'pkg build(it loadspackage.config.tsviatsImportfromtsx/esm/api).tsx 4.22.4 (privatenumber/tsx#803, "resolve CommonJS directory requires
inside dependencies") fixes the surface the SDK hits. Verified locally
on Node 24.13.0: clean
core+reactpkg buildruns pass on 4.22.4.Moves the version into a pnpm
catalogso the root and@repo/e2eshare one source of truth instead of two literal specifiers, and drops
the now-unnecessary
pnpm.overridesceiling.Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Description
What to review
Testing
Fun gif