Handle errors returned by ping gracefully#81
Merged
sanmiguel merged 1 commit intosanmiguel:masterfrom Nov 8, 2025
Merged
Conversation
sanmiguel
approved these changes
Nov 8, 2025
Owner
sanmiguel
left a comment
sanmiguel
left a comment
There was a problem hiding this comment.
Thank you for your contribution (and patience!) ❤️
I wish I could remember why this was commented out, but it's been... Some time.
Owner
|
This is failing CI because it is missing upstream changes. I'll merge as-is, and fix up anything that requires it but local testing suggest it'll be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was investigating some errors on our system, probably caused by a sudden disconnect, and stumbled upon this code. I thought it would be cleaner to handle the error more graceful and remove/reuse the commented code.