Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @santigimeno,
Thanks for this great lib! I'm using it to develop on one of my project. I've come across some issue with TypeScript when I want to organize handler functions without nesting them too much. Like the following..
The problem with the current code will be the
CardReader
as it's not exported and thetypes
is not specified inpackage.json
. This causes theonReaderDetected
above having type issue.I've made some adjustment to make this work. Please consider my PR, if it's ok to merge.