Fix crash on emulator load #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use ~isfield instead to check if SerialPort subfield is a member of BpodSystem
Contributor
|
Do you have any steps to reproduce this problem? I've experienced some funkyness from executing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JSNeuroDev and @ogeesan
I ran into an issue where launching the emulator caused the startup to crash. It seems the root of this came from two places:
BpodSystemis cleared so the two BpodLib calls fail. I moved the two calls inside ofbpod_setupwhere we can guaranteeBpodSystemalready existsisemptywill error out if a field doesn't exist,~isfieldaccomplishes the same check without an error.