Skip to content

We no longer catch an error just to throw it again. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenMaer-Parkwood wants to merge 2 commits into
base: master
Choose a base branch
from
Open

We no longer catch an error just to throw it again. #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8515f1d
We no longer catch an error just to throw it again.
BenMaer-Parkwood Apr 19, 2019
3e41a59
Removed unnecessary type declaration
BenMaer-Parkwood Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions Sources/Disk+InternalHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,20 +100,16 @@ extension Disk {

/// Find an existing file's URL or throw an error if it doesn't exist
static func getExistingFileURL(for path: String?, in directory: Directory) throws -> URL {
do {
let url = try createURL(for: path, in: directory)
if FileManager.default.fileExists(atPath: url.path) {
return url
}
let url = try createURL(for: path, in: directory)
guard FileManager.default.fileExists(atPath: url.path) else {
throw createError(
.noFileFound,
description: "Could not find an existing file or folder at \(url.path).",
failureReason: "There is no existing file or folder at \(url.path)",
recoverySuggestion: "Check if a file or folder exists before trying to commit an operation on it."
)
} catch {
throw error
}
return url
}

/// Convert a user generated name to a valid file name
Expand Down