Rabbitmq cluster for sap oc #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

matelakat wants to merge 19 commits into sap-oc:stable/sap/3.0 from matelakat:rabbitmq-cluster-for-sap-oc

matelakat commented May 30, 2017

This is the backport of crowbar#887

Also added a commit to avoid migrations happening on the backport.

vuntz added 7 commits

May 30, 2017 13:11


          rabbitmq: Remove outdated rabbitmq clustering code

f8262cf

(cherry picked from commit 33f0f04)


          rabbitmq: Enable deploying rabbitmq with clustering when doing HA

dfd14be

Clustering enables us to not require shared storage, and also to have
active/active HA for rabbitmq.

The configuration of OpenStack services needs to be adapted so that the
services are aware of the multiple rabbitmq servers, and the services
will then connect to one server, and if that connection fails, will try
to connect to another one.

(cherry picked from commit 72f5b34)

Conflicts resolved:
      chef/cookbooks/rabbitmq/templates/default/rabbitmq.config.erb
      chef/data_bags/crowbar/template-rabbitmq.json
      chef/data_bags/crowbar/template-rabbitmq.schema


          rabbitmq: Move to rabbitmq-server-ha OCF RA for cluster mode

ca89d86

This simplifies our code, but also, this resource agent has actually
more features and is designed for rabbitmq clustering, including
automatic rejoin of nodes in the cluster. In short, it's really the
resource agent we want.

(cherry picked from commit 11fa090)

Conflicts resolved:
	chef/cookbooks/rabbitmq/templates/default/rabbitmq.config.erb


          rabbitmq: Set cluster_name for rabbitmq cluster

daae229

While not mandatory, this makes it less confusing to have a cluster name
that is not based on the hostname of one cluster node.

(cherry picked from commit 5fff263)


          barbican, keystone: Move to transport_url setting for rabbitmq

97f8321

(cherry picked from commit c7a1ce8)

Conflicts resolved:
	chef/cookbooks/barbican/templates/default/barbican.conf.erb
	chef/cookbooks/keystone/templates/default/keystone.conf.erb


          crowbar-openstack: Make rabbitmq helper cluster-aware

c46191e

(cherry picked from commit 5502fc6)

Conflicts resolved:
	chef/cookbooks/crowbar-openstack/libraries/helpers.rb


          crowbar-openstack, trove: Simplify rabbitmq settings for trove

2a61410

Just do all the magic in the crowbar-openstack helper, since it knows
about clustering and everything else already.

(cherry picked from commit 1745518)

Conflicts resolved:
	chef/cookbooks/trove/libraries/helpers.rb
	chef/cookbooks/trove/recipes/api.rb
	chef/cookbooks/trove/recipes/conductor.rb
	chef/cookbooks/trove/recipes/taskmanager.rb

matelakat requested a review from vuntz

May 30, 2017 15:38

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-2418-t4ndhw/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-13075-woycmt/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-25959-9fivus/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-25995-17im392/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-2378-1kxukem/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-13068-f6x7br/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-25966-iwrku1/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-13054-1jr1yca/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-26518-1k64b23/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-2364-3o5637/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-26557-3l1qsa/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-13104-16mbeun/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-13061-1ck2ybg/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-13129-5pglgw/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-13122-1segb67/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-26539-1n8isjo/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-2371-8pjphn/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170530-26525-fvfq2v/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

crowbar_framework/app/views/barclamp/rabbitmq/_edit_attributes.html.haml

-                        = t('.ha.storage.drbd_info')
-                      = integer_field %w(ha storage drbd size)
+                    #ha_storage_container
+                      = select_field %w(ha storage mode), :collection => :ha_storage_mode_for_rabbitmq, "data-showit" => ["drbd", "shared"].join(";"), "data-showit-target" => "#drbd_storage_container;#shared_storage_container", "data-showit-direct" => "true"

houndci-bot May 30, 2017

Line is too long. [244/150]

matelakat mentioned this pull request

Move rabbitmq HA to active/active #6

Closed

Author

matelakat commented May 31, 2017 •

edited

Loading

First roadblock hit, after installing rabbit successfully, and trying to add keystone:

Failed to apply the proposal to: d52-54-77-77-01-01.virtual.cloud.suse.de 
Most recent logged lines from the Chef run:
116: 
117: if rabbits.empty? 
118: Chef::Log.warn("No RabbitMQ server found!") 
119: else 
120: one_rabbit = rabbits.first 
121>> client_ca_certs = if one_rabbit[:rabbitmq][:ssl][:enabled] && \ 
122: !one_rabbit[:rabbitmq][:ssl][:insecure] 
123: one_rabbit[:rabbitmq][:ssl][:client_ca_certs] 
124: end 
125: 
126: if rabbits.first[:rabbitmq][:cluster] 
127: rabbit_hosts = rabbits.map do |rabbit| 
128: port = if rabbit[:rabbitmq][:ssl][:enabled] 
129: rabbit[:rabbitmq][:ssl][:port] 
130: else 

[2017-05-31T09:30:20+00:00] ERROR: Running exception handlers 
[2017-05-31T09:30:20+00:00] ERROR: Report handler Chef::Handler::ErrorReport raised # 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/resource.rb:530:in `encode' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/resource.rb:530:in `to_json' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/resource.rb:530:in `to_json' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/2.1.0/json/common.rb:285:in `generate' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/2.1.0/json/common.rb:285:in `pretty_generate' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/json_compat.rb:107:in `to_json_pretty' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/handler/error_report.rb:27:in `report' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/handler.rb:226:in `run_report_unsafe' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/handler.rb:214:in `run_report_safely' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/handler.rb:118:in `block in run_exception_handlers' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/handler.rb:117:in `each' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/handler.rb:117:in `run_exception_handlers' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/handler.rb:127:in `block in ' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/client.rb:119:in `call' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/client.rb:119:in `block in run_failed' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/client.rb:118:in `each' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/client.rb:118:in `run_failed' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/client.rb:446:in `rescue in do_run' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/client.rb:455:in `do_run' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/client.rb:184:in `run' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/application.rb:133:in `run_chef_client' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/application/client.rb:306:in `block in run_application' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/application/client.rb:294:in `loop' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/application/client.rb:294:in `run_application' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/lib/chef/application.rb:65:in `run' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/lib64/ruby/gems/2.1.0/gems/chef-10.32.2/bin/chef-client:26:in `' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/bin/chef-client:23:in `load' 
[2017-05-31T09:30:20+00:00] ERROR: /usr/bin/chef-client:23:in `' 
[2017-05-31T09:30:20+00:00] ERROR: Exception handlers complete 
[2017-05-31T09:30:20+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out 
[2017-05-31T09:30:20+00:00] FATAL: NoMethodError: undefined method `[]' for nil:NilClass

vuntz and others added 8 commits

May 31, 2017 15:49


          openstack: Set amqp_durable_queues and rabbit_ha_queues options

8d1178f

(cherry picked from commit 8bd51a6)

Conflicts resolved:
	chef/cookbooks/aodh/templates/default/aodh.conf.erb
	chef/cookbooks/barbican/templates/default/barbican.conf.erb
	chef/cookbooks/ceilometer/templates/default/ceilometer.conf.erb
	chef/cookbooks/cinder/templates/default/cinder.conf.erb
	chef/cookbooks/ec2-api/templates/default/ec2api.conf.erb
	chef/cookbooks/glance/templates/default/glance-api.conf.erb
	chef/cookbooks/heat/recipes/server.rb
	chef/cookbooks/heat/templates/default/heat.conf.erb
	chef/cookbooks/keystone/templates/default/keystone.conf.erb
	chef/cookbooks/magnum/templates/default/magnum.conf.erb
	chef/cookbooks/manila/templates/default/manila.conf.erb
	chef/cookbooks/neutron/templates/default/neutron.conf.erb
	chef/cookbooks/nova/templates/default/nova.conf.erb
	chef/cookbooks/sahara/templates/default/sahara.conf.erb
	chef/cookbooks/trove/recipes/api.rb
	chef/cookbooks/trove/recipes/conductor.rb
	chef/cookbooks/trove/recipes/taskmanager.rb
	chef/cookbooks/trove/templates/default/trove-conductor.conf.erb
	chef/cookbooks/trove/templates/default/trove-taskmanager.conf.erb
	chef/cookbooks/trove/templates/default/trove.conf.erb


          openstack: Fix pacemaker ordering contraints for rabbitmq

d75caeb

When clustering is used for rabbitmq, we need to use ms-rabbitmq and not
rabbitmq in ordering constraints.

(cherry picked from commit 2d5f89a)

Conflicts resolved:
	chef/cookbooks/aodh/recipes/aodh_ha.rb
	chef/cookbooks/barbican/recipes/ha.rb
	chef/cookbooks/ceilometer/recipes/central_ha.rb
	chef/cookbooks/ceilometer/recipes/server_ha.rb
	chef/cookbooks/cinder/recipes/controller_ha.rb
	chef/cookbooks/ec2-api/recipes/ec2api_ha.rb
	chef/cookbooks/glance/recipes/ha.rb
	chef/cookbooks/heat/recipes/ha.rb
	chef/cookbooks/keystone/recipes/ha.rb
	chef/cookbooks/magnum/recipes/ha.rb
	chef/cookbooks/manila/recipes/controller_ha.rb
	chef/cookbooks/neutron/recipes/network_agents_ha.rb
	chef/cookbooks/neutron/recipes/server_ha.rb
	chef/cookbooks/nova/recipes/compute_ha.rb
	chef/cookbooks/nova/recipes/controller_ha.rb
	chef/cookbooks/sahara/recipes/ha.rb


          rabbitmq: Rework how we wait for clustered rabbitmq to be up

716abe7

Due to how the OCF resource agent is working, with the rabbit app being
started, and then stopped, and started again post-promotion, our old way
of waiting for rabbitmq was racy.

Now we wait for the pacemaker resource to be up, and check that the
rabbit app is up too.

(cherry picked from commit 06d545f)


          rabbitmq: Add additional parameters for rabbitmq pacemaker resource

46020ea

The rabbitmq-server-ha OCF resource agent is designed to work with
rabbitmq 3.6.x by default, we need to turn off some features for the
version we ship (3.4.x).

(cherry picked from commit 629d084)


          rabbitmq: Define vhost to watch for pacemaker resource

3f85648

This is a new parameter for the rabbitmq-server-ha OCF resource agent,
introduced in
rabbitmq/rabbitmq-server-release#24

It's required to make sure that we monitor the right vhost when ensuring
synchronization.

(cherry picked from commit 373561c)


          rabbit: avoid migrations on backport

3e76981

In order to avoid migrations in backported patch, removing earlier
introduced migration scripts. Given that the default value for cluster
is false, this will leave rabbit on it's original, non-clustered
configuration.


          Remove ssl settings

67b2b95

While backporting the patch, accidentally some rabbit-ssl related code
sneaked in. Removing that.


          Add transport_url for missing components

66c8bf8

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-16532-1g0ldfg/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-16503-1kxuvi3/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-16557-k35a7g/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-25749-1jdc8p1/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-22592-fm7uom/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-5344-1sublko/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-22574-wsd3a/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-5362-1tm64wq/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-25728-1vkqedh/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-16550-st9pco/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-25735-lb3shi/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-5337-cargva/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-25674-13cwjhd/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-5330-ws5zuj/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-22567-1d9bx6k/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-25692-1tmvgxp/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-5323-2qgphw/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...

Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-25742-13ip27p/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true


          expose the same variables for templates

06e39f3

Earlier changes modified the structure of `rabbitmq_settings` hash,
which meant that even if people just deployed new cookbooks, the next
periodic chef run would modify config files and thus trigger service
restarts. This change adds back the same structures and also adds a flag
to the `rabbitmq_settings` structure to indicate it's legaciness.

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

/tmp/d20170601-7812-68c6el/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170601-7812-68c6el/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-7812-68c6el/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-7812-68c6el/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-7812-68c6el/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-7812-68c6el/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-7812-68c6el/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-12687-1r5bc0d/.rubocop.yml: Style/AlignHash has the wrong name...

/tmp/d20170601-12687-1r5bc0d/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-12687-1r5bc0d/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-12687-1r5bc0d/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-12687-1r5bc0d/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-12687-1r5bc0d/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-12687-1r5bc0d/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-14611-1bbpsoa/.rubocop.yml: Style/AlignHash has the wrong name...

/tmp/d20170601-14611-1bbpsoa/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-14611-1bbpsoa/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-14611-1bbpsoa/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-14611-1bbpsoa/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-14611-1bbpsoa/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-14611-1bbpsoa/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-14639-12o6slj/.rubocop.yml: Style/AlignHash has the wrong name...

/tmp/d20170601-14639-12o6slj/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-14639-12o6slj/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-14639-12o6slj/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-14639-12o6slj/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-14639-12o6slj/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-14639-12o6slj/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-3725-owauii/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170601-3725-owauii/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-3725-owauii/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-3725-owauii/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-3725-owauii/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-3725-owauii/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-3725-owauii/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-3718-1gxygh1/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-3718-1gxygh1/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-3718-1gxygh1/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-3718-1gxygh1/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-3718-1gxygh1/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-3718-1gxygh1/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-3718-1gxygh1/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-12701-uj0izp/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-12701-uj0izp/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-12701-uj0izp/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-12701-uj0izp/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-12701-uj0izp/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-12701-uj0izp/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-12701-uj0izp/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-3697-15j2i5f/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-3697-15j2i5f/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-3697-15j2i5f/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-3697-15j2i5f/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-3697-15j2i5f/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-3697-15j2i5f/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-3697-15j2i5f/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-7805-16tl215/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-7805-16tl215/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-7805-16tl215/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-7805-16tl215/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-7805-16tl215/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-7805-16tl215/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-7805-16tl215/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-12708-l0875x/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-12708-l0875x/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-12708-l0875x/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-12708-l0875x/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-12708-l0875x/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-12708-l0875x/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-12708-l0875x/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-3711-1l6rngj/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-3711-1l6rngj/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-3711-1l6rngj/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-3711-1l6rngj/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-3711-1l6rngj/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-3711-1l6rngj/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-3711-1l6rngj/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-14618-4kecra/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-14618-4kecra/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-14618-4kecra/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-14618-4kecra/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-14618-4kecra/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-14618-4kecra/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-14618-4kecra/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-14632-1boz2i7/.rubocop.yml: Style/AlignHash has the wrong name...

/tmp/d20170601-14632-1boz2i7/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-14632-1boz2i7/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-14632-1boz2i7/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-14632-1boz2i7/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-14632-1boz2i7/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-14632-1boz2i7/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-7826-1qe8qn6/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-7826-1qe8qn6/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-7826-1qe8qn6/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-7826-1qe8qn6/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-7826-1qe8qn6/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-7826-1qe8qn6/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-7826-1qe8qn6/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-7819-19vn4iy/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-7819-19vn4iy/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-7819-19vn4iy/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-7819-19vn4iy/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-7819-19vn4iy/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-7819-19vn4iy/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-7819-19vn4iy/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-12694-1xtrzj2/.rubocop.yml: Style/AlignHash has the wrong name...

/tmp/d20170601-12694-1xtrzj2/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-12694-1xtrzj2/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-12694-1xtrzj2/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-12694-1xtrzj2/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-12694-1xtrzj2/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-12694-1xtrzj2/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-14625-4rcqub/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-14625-4rcqub/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-14625-4rcqub/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-14625-4rcqub/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-14625-4rcqub/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-14625-4rcqub/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-14625-4rcqub/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170601-14604-6sa6gc/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170601-14604-6sa6gc/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170601-14604-6sa6gc/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170601-14604-6sa6gc/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170601-14604-6sa6gc/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170601-14604-6sa6gc/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170601-14604-6sa6gc/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

crowbar_framework/app/views/barclamp/rabbitmq/_edit_attributes.html.haml

+                          = t('.ha.storage.drbd_info')
+                        = integer_field %w(ha storage drbd size)
+                      #shared_storage_container

houndci-bot Jun 1, 2017

id attribute must be in lisp-case

crowbar_framework/app/views/barclamp/rabbitmq/_edit_attributes.html.haml

-                      = string_field %w(ha storage shared device)
-                      = string_field %w(ha storage shared fstype)
-                      = string_field %w(ha storage shared options)
+                      #drbd_storage_container

houndci-bot Jun 1, 2017

id attribute must be in lisp-case

crowbar_framework/app/views/barclamp/rabbitmq/_edit_attributes.html.haml

-                      .alert.alert-info
-                        = t('.ha.storage.drbd_info')
-                      = integer_field %w(ha storage drbd size)
+                    #ha_storage_container

houndci-bot Jun 1, 2017

id attribute must be in lisp-case

Mate Lakat added 2 commits

June 6, 2017 10:29


          refactor: Use one_rabbit variable

85cddab

replace occurences of rabbits.first


          Format neutron config file

6d4bd35

In order to avoid file changes and thus service restarts, re format the
code so it look like the original one.

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6725-hhzcqz/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6725-hhzcqz/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7847-1a2wjmk/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7847-1a2wjmk/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7930-12949i1/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7930-12949i1/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7854-iyyhqm/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7854-iyyhqm/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1599-1l6bzy6/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1599-1l6bzy6/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1541-ctql6p/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1541-ctql6p/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6750-1maz02o/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6750-1maz02o/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7948-1kagj29/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7948-1kagj29/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1639-x8p508/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1639-x8p508/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6718-3t0kov/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6718-3t0kov/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6815-1j8lx78/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6815-1j8lx78/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6768-rjvtvw/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6768-rjvtvw/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7923-2ex1h1/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7923-2ex1h1/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1570-1q2cb6q/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1570-1q2cb6q/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6631-2rp381/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6631-2rp381/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1527-a5suct/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1527-a5suct/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6743-mr50x5/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6743-mr50x5/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7872-ysxpl3/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7872-ysxpl3/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6725-hhzcqz/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6725-hhzcqz/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6725-hhzcqz/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7847-1a2wjmk/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7847-1a2wjmk/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7847-1a2wjmk/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7930-12949i1/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7930-12949i1/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7930-12949i1/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7854-iyyhqm/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7854-iyyhqm/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7854-iyyhqm/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1599-1l6bzy6/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1599-1l6bzy6/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1599-1l6bzy6/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1541-ctql6p/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1541-ctql6p/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1541-ctql6p/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6750-1maz02o/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6750-1maz02o/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6750-1maz02o/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7948-1kagj29/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7948-1kagj29/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7948-1kagj29/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1639-x8p508/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1639-x8p508/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1639-x8p508/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6718-3t0kov/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6718-3t0kov/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6718-3t0kov/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6815-1j8lx78/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6815-1j8lx78/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6815-1j8lx78/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6768-rjvtvw/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6768-rjvtvw/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6768-rjvtvw/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7923-2ex1h1/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7923-2ex1h1/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7923-2ex1h1/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/AlignHash has the wrong names...

/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1570-1q2cb6q/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1570-1q2cb6q/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1570-1q2cb6q/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6631-2rp381/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6631-2rp381/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6631-2rp381/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-1527-a5suct/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-1527-a5suct/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-1527-a5suct/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-6743-mr50x5/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-6743-mr50x5/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-6743-mr50x5/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/AlignHash has the wrong namesp...

/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170606-7872-ysxpl3/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170606-7872-ysxpl3/.rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170606-7872-ysxpl3/.rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

matelakat commented

View reviewed changes

chef/cookbooks/rabbitmq/templates/default/rabbitmq.config.erb

                                   <%= node[:rabbitmq][:addresses].map { |address| "{\"#{address}\", #{node[:rabbitmq][:port]}}" }.join(", ") %>
                                  ]},
+                 {cluster_nodes, {[
+                                   <%= @cluster_nodes %>

Author

matelakat Jun 16, 2017

This seems to be empty

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in .rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in .rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in .rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in .rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in .rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith


          Fix: add nodes to rabbit conf

a93b38e

The variable @cluster_nodes was not exposed to the template. Amended the
template, so configuration will not change in case we install the
package on top of a non-clustered setup (that's why the clustered
variable was introduced), and export the list of hosts.

houndci-bot reviewed

View reviewed changes

houndci-bot left a comment

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter RunRailsCops (for AllCops) found in .rubocop.yml
Use the following configuration instead:
Rails:
  Enabled: true
obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
AlignWith has been renamed to EnforcedStyleAlignWith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet