Staging pgtune #49

matelakat · 2017-07-06T09:12:44Z

This is the re-based version of #20

In order to be able to re-trigger the CI

This recipe contains fine-tuning to make sure that postgresql is configured the correct way on the node is being deployed to (in terms of memory usage, for instance). (cherry picked from commit acf6a53)

There are a couple of fixes that we want from https://github.com/sous-chefs/postgresql/blob/master/recipes/config_pgtune.rb (cherry picked from commit bc7292280dccd5e89721ec0869fc69662cff096f)

Now that we enable the config_pgtune recipe, the max_connection settings must live there. This mostly reverts 251a5de. (cherry picked from commit 42d14f66336caf0b0d88541f919da3fcef054790)

houndci-bot · 2017-07-06T09:12:54Z

chef/data_bags/crowbar/migrate/database/010_pgtune.rb

+
+def downgrade(ta, td, a, d)
+  if ta["postgresql"]["config"].key?("max_connections")
+    a["postgresql"]["config"]["max_connections"] = a["postgresql"]["config_pgtune"]["max_connections"]


Metrics/LineLength: Line is too long. [102/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

houndci-bot · 2017-07-06T09:12:55Z

chef/data_bags/crowbar/migrate/database/010_pgtune.rb

+def upgrade(ta, td, a, d)
+  a["postgresql"]["config_pgtune"] ||= {}
+  unless a["postgresql"]["config_pgtune"].key?("max_connections")
+    a["postgresql"]["config_pgtune"]["max_connections"] = a["postgresql"]["config"]["max_connections"]


Metrics/LineLength: Line is too long. [102/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    "dw" => 500,
+    "mixed" => 100,
+    "desktop" => 100,
+  }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    "oltp" => 100,
+    "dw" => 500,
+    "mixed" => 100,
+    "desktop" => 100,


Style/TrailingCommaInLiteral: Avoid comma after the last item of a hash. (https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    "dw" => "0.9",
+    "mixed" => "0.9",
+    "desktop" => "0.5",
+  }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "oltp" => mem / 16,
+      "dw" => mem / 8,
+      "mixed" => mem / 16,
+      "desktop" => mem / 16,


Style/TrailingCommaInLiteral: Avoid comma after the last item of a hash. (https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "dw" => mem_con_v / 2,
+      "mixed" => mem_con_v / 2,
+      "desktop" => mem_con_v / 6,
+    }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "oltp" => mem_con_v,
+      "dw" => mem_con_v / 2,
+      "mixed" => mem_con_v / 2,
+      "desktop" => mem_con_v / 6,


Style/TrailingCommaInLiteral: Avoid comma after the last item of a hash. (https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    }.fetch(db_type)

-  node.default["postgresql"]["config"]["effective_cache_size"] = binaryround(effective_cache_size*1024*1024)
+  node.default["postgresql"]["config"]["effective_cache_size"] = binaryround(effective_cache_size * 1024 * 1024)


Metrics/LineLength: Line is too long. [112/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

houndci-bot · 2017-07-06T09:12:55Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "dw" => mem * 3 / 4,
+      "mixed" => mem * 3 / 4,
+      "desktop" => mem / 4,
+    }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

houndci-bot · 2017-07-06T09:12:57Z

chef/data_bags/crowbar/migrate/database/010_pgtune.rb

+
+def downgrade(ta, td, a, d)
+  if ta["postgresql"]["config"].key?("max_connections")
+    a["postgresql"]["config"]["max_connections"] = a["postgresql"]["config_pgtune"]["max_connections"]


Metrics/LineLength: Line is too long. [102/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

houndci-bot · 2017-07-06T09:12:57Z

chef/data_bags/crowbar/migrate/database/010_pgtune.rb

+def upgrade(ta, td, a, d)
+  a["postgresql"]["config_pgtune"] ||= {}
+  unless a["postgresql"]["config_pgtune"].key?("max_connections")
+    a["postgresql"]["config_pgtune"]["max_connections"] = a["postgresql"]["config"]["max_connections"]


Metrics/LineLength: Line is too long. [102/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

houndci-bot · 2017-07-06T09:12:57Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    "dw" => 500,
+    "mixed" => 100,
+    "desktop" => 100,
+  }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

houndci-bot · 2017-07-06T09:12:57Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    "oltp" => 100,
+    "dw" => 500,
+    "mixed" => 100,
+    "desktop" => 100,


Style/TrailingCommaInLiteral: Avoid comma after the last item of a hash. (https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)

houndci-bot · 2017-07-06T09:12:57Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    "dw" => "0.9",
+    "mixed" => "0.9",
+    "desktop" => "0.5",
+  }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

houndci-bot · 2017-07-06T09:12:57Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "oltp" => mem / 16,
+      "dw" => mem / 8,
+      "mixed" => mem / 16,
+      "desktop" => mem / 16,


Style/TrailingCommaInLiteral: Avoid comma after the last item of a hash. (https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)

houndci-bot · 2017-07-06T09:12:57Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "dw" => mem_con_v / 2,
+      "mixed" => mem_con_v / 2,
+      "desktop" => mem_con_v / 6,
+    }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

houndci-bot · 2017-07-06T09:12:57Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "oltp" => mem_con_v,
+      "dw" => mem_con_v / 2,
+      "mixed" => mem_con_v / 2,
+      "desktop" => mem_con_v / 6,


Style/TrailingCommaInLiteral: Avoid comma after the last item of a hash. (https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)

houndci-bot · 2017-07-06T09:12:57Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+    }.fetch(db_type)

-  node.default["postgresql"]["config"]["effective_cache_size"] = binaryround(effective_cache_size*1024*1024)
+  node.default["postgresql"]["config"]["effective_cache_size"] = binaryround(effective_cache_size * 1024 * 1024)


Metrics/LineLength: Line is too long. [112/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

houndci-bot · 2017-07-06T09:12:58Z

chef/cookbooks/postgresql/recipes/config_pgtune.rb

+      "dw" => mem * 3 / 4,
+      "mixed" => mem * 3 / 4,
+      "desktop" => mem / 4,
+    }.fetch(db_type)


Layout/MultilineHashBraceLayout: Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.

vuntz added 3 commits July 6, 2017 11:11

postgresql: Use the config_pgtune recipe

f1331ba

This recipe contains fine-tuning to make sure that postgresql is configured the correct way on the node is being deployed to (in terms of memory usage, for instance). (cherry picked from commit acf6a53)

postgresql: Synchronize pg_tune recipe with upstream

b18b162

There are a couple of fixes that we want from https://github.com/sous-chefs/postgresql/blob/master/recipes/config_pgtune.rb (cherry picked from commit bc7292280dccd5e89721ec0869fc69662cff096f)

postgresql: Move max_connection settings to config_pgtune

c98144d

Now that we enable the config_pgtune recipe, the max_connection settings must live there. This mostly reverts 251a5de. (cherry picked from commit 42d14f66336caf0b0d88541f919da3fcef054790)

houndci-bot reviewed Jul 6, 2017

View reviewed changes

Staging pgtune #49

Are you sure you want to change the base?

Staging pgtune #49

Uh oh!

Conversation

matelakat commented Jul 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matelakat commented Jul 6, 2017 •

edited

Loading