Backport fix postgresql and rabbitmq crm services #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, the rabbitmq OCF resource agent cannot be restarted by crowbar. When running in HA mode, if the service is notified to restart, both controller nodes will claim that the service is not running. Since it is managed as a special OCF resource agent instead of as a systemd resource, it is necessary to use crm to check whether it is running and to restart it. Moreover, the rabbitmq OCF is named 'rabbitmq' even though the systemd service is named 'rabbitmq-server'. This patch adds the necessary fields to the 'supports' parameter for the rabbitmq service so that it can be properly restarted if necessary. This was not noticed previously because the configuration options for rabbitmq are rarely changed and so rabbitmq rarely requires a restart. However, the resource limits management feature added in pr#974 requires potentially multiple service restarts after initial deployment as parameters are tuned over time, so we need to make sure crowbar is capable of it. (cherry picked from commit b08aaa1)
Without this patch, the postgresql OCF resource agent cannot be restarted by crowbar. When running in HA mode, if the service is notified to restart, both controller nodes will claim that the service is not running. Since it is managed as a special OCF resource agent instead of as a systemd resource, it is necessary to use crm to check whether it is running and to restart it. This patch sets the restart_crm_resource field in the 'supports' parameter for the postgresql service so that it can be properly restarted if necessary. This was not noticed previously because the configuration options for postgresql are rarely changed and so postgresql rarely requires a restart. However, the resource limits management feature added in pr#974 requires potentially multiple service restarts after initial deployment as parameters are tuned over time, so we need to make sure crowbar is capable of it. (cherry picked from commit b492d7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of crowbar#1029
Fixes #50