Skip to content

fix(akamai): add propagation timeout to prevent worker thread from hanging #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notandy wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

fix(akamai): add propagation timeout to prevent worker thread from hanging #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,9 @@ type AkamaiConfig struct {
Domain string `yaml:"domain" description:"Traffic Management Domain to use (e.g. production.akadns.net)."`
DomainType string `yaml:"domain_type" description:"Indicates the type of domain available based on your contract, defaults to autodetect. Either failover-only, static, weighted, basic, or full."`
ContractId string `yaml:"contract_id" description:"Indicated the contract id to use, autodetects if only one contract is associated."`
SyncInterval int64 `yaml:"sync_interval" default:"30" description:"Sync interval for checking for pending updates"`
MemberStatusInterval int64 `yaml:"member_status_interval" default:"60" description:"Sync interval for checking for member status"`
SyncInterval int64 `yaml:"sync_interval" default:"30" description:"Sync interval for checking for pending updates"`
MemberStatusInterval int64 `yaml:"member_status_interval" default:"60" description:"Sync interval for checking for member status"`
PropagationTimeout int64 `yaml:"propagation_timeout" default:"300" description:"Maximum time in seconds to wait for Akamai propagation before giving up"`
}

type Audit struct {
Expand Down
5 changes: 5 additions & 0 deletions internal/driver/akamai/datacenter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ func (s *AkamaiAgent) FetchAndSyncDatacenters(datacenters []string, force bool)

// Wait for status propagation
var status string
deadline := time.Now().Add(time.Duration(config.Global.AkamaiConfig.PropagationTimeout) * time.Second)
for ok := true; ok; ok = status == "PENDING" {
if time.Now().After(deadline) {
log.Errorf("FetchAndSyncDatacenters: propagation timeout after %ds", config.Global.AkamaiConfig.PropagationTimeout)
break
}
time.Sleep(5 * time.Second)
status, err = s.syncProvisioningStatus(nil)
if err != nil {
Expand Down
5 changes: 5 additions & 0 deletions internal/driver/akamai/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,12 @@ func (s *AkamaiAgent) FetchAndSyncDomains(domains []string, force bool) error {

// Wait for status propagation
var status string
deadline := time.Now().Add(time.Duration(config.Global.AkamaiConfig.PropagationTimeout) * time.Second)
for ok := true; ok; ok = status == "PENDING" {
if time.Now().After(deadline) {
log.Errorf("domainSync(%s): propagation timeout after %ds", domain.Id, config.Global.AkamaiConfig.PropagationTimeout)
break
}
time.Sleep(5 * time.Second)
status, err = s.syncProvisioningStatus(domain)
if err != nil {
Expand Down
5 changes: 5 additions & 0 deletions internal/driver/akamai/geomap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,12 @@ func (s *AkamaiAgent) FetchAndSyncGeomaps(geomaps []string, force bool) error {

// Wait for status propagation
var status string
deadline := time.Now().Add(time.Duration(config.Global.AkamaiConfig.PropagationTimeout) * time.Second)
for ok := true; ok; ok = status == "PENDING" {
if time.Now().After(deadline) {
log.Errorf("FetchAndSyncGeomaps: propagation timeout after %ds", config.Global.AkamaiConfig.PropagationTimeout)
break
}
time.Sleep(5 * time.Second)
status, err = s.syncProvisioningStatus(nil)
if err != nil {
Expand Down
Loading