Skip to content

Fix already added tests #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
videlov merged 1 commit into from
Feb 3, 2026
Merged

Fix already added tests #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 57 additions & 10 deletions internal/controller/ipupdate_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,31 +174,39 @@ var _ = Describe("IP Update Controller", func() {
By("cleanup IPAM IPAddress")
ipAddress := &ipamv1.IPAddress{}
if err := k8sClient.Get(ctx, typeNamespacedUpdateName, ipAddress); err == nil {
_ = k8sClient.Delete(ctx, ipAddress)
ipAddress.Finalizers = nil
Expect(k8sClient.Update(ctx, ipAddress)).To(Succeed())
Expect(k8sClient.Delete(ctx, ipAddress)).To(Succeed())
}

By("cleanup IPAM IPAddressClaim")
ipClaim := &ipamv1.IPAddressClaim{}
if err := k8sClient.Get(ctx, types.NamespacedName{
Name: "test-claim", Namespace: resourceNamespace,
}, ipClaim); err == nil {
_ = k8sClient.Delete(ctx, ipClaim)
ipClaim.Finalizers = nil
Expect(k8sClient.Update(ctx, ipClaim)).To(Succeed())
Expect(k8sClient.Delete(ctx, ipClaim)).To(Succeed())
}

By("cleanup ServerClaim")
serverClaim := &metalv1alpha1.ServerClaim{}
if err := k8sClient.Get(ctx, types.NamespacedName{
Name: "test-server-claim", Namespace: resourceNamespace,
}, serverClaim); err == nil {
_ = k8sClient.Delete(ctx, serverClaim)
serverClaim.Finalizers = nil
Expect(k8sClient.Update(ctx, serverClaim)).To(Succeed())
Expect(k8sClient.Delete(ctx, serverClaim)).To(Succeed())
}

By("cleanup Server")
server := &metalv1alpha1.Server{}
if err := k8sClient.Get(ctx, types.NamespacedName{
Name: "test-server", Namespace: resourceNamespace,
}, server); err == nil {
_ = k8sClient.Delete(ctx, server)
server.Finalizers = nil
Expect(k8sClient.Update(ctx, server)).To(Succeed())
Expect(k8sClient.Delete(ctx, server)).To(Succeed())
}
})

Expand Down Expand Up @@ -228,6 +236,11 @@ var _ = Describe("IP Update Controller", func() {
_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("failed to get IPAddressClaim for IPAddress:"))
Expand All @@ -248,6 +261,11 @@ var _ = Describe("IP Update Controller", func() {
_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("no ServerClaim owner"))
Expand Down Expand Up @@ -277,10 +295,14 @@ var _ = Describe("IP Update Controller", func() {
},
}
Expect(k8sClient.Create(ctx, serverClaim)).To(Succeed())

_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("not yet bound to a server"))
Expand All @@ -296,10 +318,14 @@ var _ = Describe("IP Update Controller", func() {
Namespace: resourceNamespace,
}, server)).To(Succeed())
Expect(k8sClient.Delete(ctx, server)).To(Succeed())

_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("failed to get Server referenced by ServerClaim"))
Expand All @@ -317,10 +343,14 @@ var _ = Describe("IP Update Controller", func() {

server.Spec.BMCRef.Name = ""
Expect(k8sClient.Update(ctx, server)).To(Succeed())

_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("has no bmcRef name"))
Expand All @@ -341,6 +371,11 @@ var _ = Describe("IP Update Controller", func() {
_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("failed to get ServerClaim"))
Expand All @@ -355,10 +390,14 @@ var _ = Describe("IP Update Controller", func() {
}

controllerReconciler := createIPUpdateReconciler(netBoxMock, fileReaderMock)

_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("device not found"))
Expand All @@ -373,10 +412,14 @@ var _ = Describe("IP Update Controller", func() {
}

controllerReconciler := createIPUpdateReconciler(netBoxMock, fileReaderMock)

_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("failed to list interfaces"))
Expand All @@ -396,10 +439,14 @@ var _ = Describe("IP Update Controller", func() {
}

controllerReconciler := createIPUpdateReconciler(netBoxMock, fileReaderMock)

_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})
Expect(err).ToNot(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: typeNamespacedUpdateName,
})

Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("no LAG interface found"))
Expand Down
Loading