Skip to content

Conversation

@defo89
Copy link
Member

@defo89 defo89 commented Jan 12, 2026

No description provided.

@defo89 defo89 requested a review from videlov January 12, 2026 16:20
Copy link
Collaborator

@goerangudat goerangudat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/argora/api/v1alpha1 26.57% (ø)
github.com/sapcc/argora/internal/controller 81.31% (+0.45%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/argora/api/v1alpha1/common.go 0.00% (ø) 0 0 0
github.com/sapcc/argora/internal/controller/ippoolimport_controller.go 83.87% (+2.55%) 93 (+2) 78 (+4) 15 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/argora/internal/controller/ippoolimport_controller_test.go

@defo89 defo89 merged commit d73da6f into main Jan 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants