Conversation
SuperSandro2000
requested review from
Nuckal777,
VoigtS,
majewsky and
wagnerd3
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
majewsky
approved these changes
Mar 28, 2025
Contributor
majewsky
left a comment
majewsky
left a comment
There was a problem hiding this comment.
I think I'm fine with this in general. Do we want to have the .typos.toml autogenerated? The contents look highly specific to this repo. Maybe we generate one on first setup with a link to the documentation and a default set of excludes (go.mod and vendor) and then leave it to the repo owner to maintain it from that point?
Member
Author
|
Without templating support? We can do that |
majewsky
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misspell doesn't find that much typos. Typos is an alternative that finds more and generally has a low false positive rate.
I found two lala things in here: DELETEs and the rsa keys are not fully detected correctly but I think that doesn't outweigh the advantages.