-
Notifications
You must be signed in to change notification settings - Fork 5
utilize ServiceInfo from database for collect-startup and serve-tasks #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
78d73c6
to
b62e775
Compare
b62e775
to
68a0a96
Compare
68a0a96
to
02df4cd
Compare
I have adressed the comments from @majewsky now. I initially started to pass through the errors of all the small helper functions everywhere, but quickly realized that by checking for the errors everywhere the code gets very messy. Additionally, because of the many specific methods to access the I did solve this a little bit different now: On Cluster level, the access is just possible to access all I had to add this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself, I have not checked internal/collector/metrics.go
yet because I ran out of time on this review.
Checklist:
Contents of this PR:
Cluster
objectDataMetricsReporter
is the only user which caches the info for the duration of one assembly of the metricsLiquidConnection
s directlyThis is not yet tested properly for all cases, because the datasources in qa-de-1 are partially down. Therefore opening as draft for now.