Skip to content

merge ScrapeJob and ScrapeRatesJob #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Varsius
Copy link
Contributor

@Varsius Varsius commented May 30, 2025

No description provided.

@coveralls
Copy link

coveralls commented May 30, 2025

Coverage Status

coverage: 79.106%. first build
when pulling 58bcdd0 on merge-scrape-and-scrape-rates-job
into acd4a77 on master.

@Varsius Varsius force-pushed the merge-scrape-and-scrape-rates-job branch 2 times, most recently from 84a3f55 to 3362fa5 Compare June 2, 2025 07:41
@Varsius Varsius force-pushed the merge-scrape-and-scrape-rates-job branch from 3362fa5 to 3284ac9 Compare June 4, 2025 13:37
@Varsius Varsius requested a review from majewsky June 5, 2025 11:57
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have some minor notes:

@Varsius Varsius requested a review from majewsky June 10, 2025 14:10
@Varsius Varsius force-pushed the merge-scrape-and-scrape-rates-job branch from b2725df to 899037a Compare June 11, 2025 12:00
majewsky
majewsky previously approved these changes Jun 11, 2025
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants