Fix ValueError('Incorrect label names')#160
Merged
sven-rosenzweig merged 1 commit intostable/2024.1-m3from Jan 21, 2026
Merged
Conversation
When request errors occur (e.g. ConnectTimeout), the `resource` label was passed instead of `resource_type` as label causing the error.
sven-rosenzweig
force-pushed
the
fix_metrics
branch
from
0915818 to
b822d0a
Compare
sebageek
approved these changes
Jan 20, 2026
|
felix-kaestner
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When request errors occur (e.g. ConnectTimeout),
the
pathlabel was not added to the Prometheus metric, causing a ValueError.