Skip to content

fix(utilities): ensure consistent typing for objectEntries, objectKeys and objectValues #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
favna merged 6 commits into from
Jan 29, 2025
Merged

fix(utilities): ensure consistent typing for objectEntries, objectKeys and objectValues #857

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d6d3e8
fix(objectEntries): Updated wrong type assertion
GeniusTimo Jan 18, 2025
34c3205
fix(objectEntries): Updated return type to be consistent with the typ…
GeniusTimo Jan 18, 2025
b43fba0
fix(objectKeys): Updated wrong type assertion
GeniusTimo Jan 18, 2025
de87080
fix(objectValues): Updated return type to be consistent with objectEn…
GeniusTimo Jan 18, 2025
e506d2a
test(utilities): Added some additional test cases
GeniusTimo Jan 20, 2025
d00bc43
Merge branch 'main' into patch-1
favna Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/utilities/src/lib/objectEntries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export function objectEntries<T extends object>(obj: T): T extends ArrayLike<any> ? [`${number}`, T[number]][] : [keyof T, T[keyof T]][] {
return Object.entries(obj) as T extends ArrayLike<infer Values> ? Values[] : [keyof T, T[keyof T]][];
export function objectEntries<T extends object>(obj: T): T extends ArrayLike<infer Values> ? [`${number}`, Values][] : [keyof T, T[keyof T]][] {
return Object.entries(obj) as T extends ArrayLike<infer Values> ? [`${number}`, Values][] : [keyof T, T[keyof T]][];
}
2 changes: 1 addition & 1 deletion packages/utilities/src/lib/objectKeys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export function objectKeys<T extends object>(obj: T): T extends ArrayLike<any> ? `${number}`[] : (keyof T)[] {
return Object.keys(obj) as T extends ArrayLike<infer Values> ? Values[] : (keyof T)[];
return Object.keys(obj) as T extends ArrayLike<any> ? `${number}`[] : (keyof T)[];
}
2 changes: 1 addition & 1 deletion packages/utilities/src/lib/objectValues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export function objectValues<T extends object>(obj: T): T extends ArrayLike<any> ? T[number][] : T[keyof T][] {
export function objectValues<T extends object>(obj: T): T extends ArrayLike<infer Values> ? Values[] : T[keyof T][] {
return Object.values(obj) as T extends ArrayLike<infer Values> ? Values[] : T[keyof T][];
}
Loading